feat(deps): bump mongosh, driver to latest COMPASS-9056 #6774
Conversation
This includes adjusting the CSFLE/QE collection tracker for the Node.js driver changes related to `$lookup` support, where filters for listCollections can now list multiple collections in an `$in` clause.
| `[Compass] Unexpected listCollections request on '${dbName}' with name: '${ | ||
| filter?.name as string | ||
| }'` | ||
| `[Compass] Unexpected listCollections request on '${dbName}' with filter: ${EJSON.stringify( |
There was a problem hiding this comment.
[nit] Should we include the shape of the filter that we expect? I find it a much nicer DX when I get an error that not only tells me that I did something wrong, but also helps me do the right thing
There was a problem hiding this comment.
We could, but honestly I don't think that would be worth it, if this actually gets thrown at some point, that means we're going to have to do some digging into the root cause anyway
| @@ -437,53 +446,70 @@ export class CSFLECollectionTrackerImpl implements CSFLECollectionTracker { | |||
| filter: Document, | |||
| collectionInfos: CollectionInfo[] | |||
| ): Error | undefined { | |||
| if (typeof filter?.name !== 'string' || collectionInfos.length > 1) { | |||
| // filter is either { name: string } or { name: { $in: string[] } } | |||
There was a problem hiding this comment.
can this be documented as a type?
There was a problem hiding this comment.
Yeah, but the point here is that the input isn't of a known type ... we could split this out into a separate validation function if you prefer, that takes a generic unknown or Document input and returns this type
There was a problem hiding this comment.
I see, I don't have strong feelings about it; leaving it as is is fine also 👍
This includes adjusting the CSFLE/QE collection tracker for the Node.js driver changes related to
$lookupsupport, where filters for listCollections can now list multiple collections in an$inclause.Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes